[9.4] [EA] Fix flaky entities_table_grouping: extend @entityStoreSearch timeout (#268217)#268309
Merged
Merged
Conversation
…eout (elastic#268217) ## Summary Fixes intermittent failures in `entities_table_grouping.cy.ts` reported in: - elastic#267794 - elastic#267795 - elastic#267828 - elastic#267965 ### Root Cause PR elastic#265125 added `interceptEntityStoreStatus('running')` + `cy.wait('@entityStoreStatus', { timeout: 20000 })` to every `beforeEach` to prevent the page from showing `EntityStoreDisabledEmptyPrompt`. The intent was correct, but after `@entityStoreStatus` resolves, the page still needs to: 1. React re-render with the new status data 2. Wait for `isSourcererLoading = false` (the sourcerer / data-view initialization) 3. Mount `EntitiesTableSection` 4. Fire the POST to `/internal/search/ese` This cascade can easily take **> 5 s** in slow CI environments, while `cy.wait('@entityStoreSearch')` was left with the default **5 s timeout** — causing "No request ever occurred" failures. ### Changes **Option A** — raise the `@entityStoreSearch` timeout to 20 s, matching `@entityStoreStatus`. **Option B** — consolidate `cy.wait('@entityStoreStatus')` + `cy.wait('@entityStoreSearch')` + `waitForGroupingTable()` into a single `waitForEntityAnalyticsPageReady()` task helper, so the three `beforeEach` blocks stay DRY and the timeout logic lives in one place. Both options are implemented together: the helper encapsulates the correct timeouts and every `beforeEach` now calls `waitForEntityAnalyticsPageReady()`. ## Test plan - [ ] Verify `entities_table_grouping.cy.ts` passes locally - [ ] Check CI on this PR for the three previously-failing suites (Group by Resolution, Switching grouping) ## Checklist - [x] No hardcoded waits (`cy.wait(ms)`) introduced - [x] No `eslint-disable` introduced - [x] Existing tests unchanged — only `beforeEach` wiring consolidated Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit fd88e7f)
5 tasks
Contributor
Author
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation